Added comments to posts #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const CN = 'loading-center'; | ||
| export const LoadingIndicator = () => { | ||
| return ( | ||
|
|
There was a problem hiding this comment.
Empty lines on lines 4,8,13 are useless and can be deleted
| animation: loadingspin 2s linear infinite; | ||
| } | ||
|
|
||
|
|
| 100% { | ||
| transform: rotate(360deg) | ||
| } | ||
|
|
| import { PostImage } from '../PostImage/PostImage'; | ||
| import { accessToken } from '../../constants'; | ||
| import React, {Component} from "react"; | ||
| import {accessToken} from '../../constants'; | ||
| import "./Post.scss"; |
There was a problem hiding this comment.
Styling import should be the last one on line 7
| if (!commentsLoaded) { | ||
| return this.onLoadComments() | ||
| } else { | ||
| return this.setState({commentsSectionExpanded: !commentsSectionExpanded}); |
There was a problem hiding this comment.
You can skip return here just use
this.onLoadComments()
and
this.setState({commentsSectionExpanded: !commentsSectionExpanded});
| <div className={`${CN}__link-btn`} onClick={this.onShowComments}> | ||
| {commentsSectionExpanded ? "Hide comments" : "Show comments"} | ||
| </div> | ||
| <div> |
There was a problem hiding this comment.
This div is not needed and can be deleted
| } | ||
| { | ||
| {commentsSectionExpanded && !isCommentsLoading && commentsLoaded && !comments.length && | ||
| <div className={`${CN}__no-results`}>{"No comments for this post yet"}</div>} |
There was a problem hiding this comment.
Brackets are not needed here inside tag cause you are putting simple string as a child
can be just
<div className={${CN}__no-results}>"No comments for this post yet"</div>
| @@ -1,9 +1,9 @@ | |||
| import React, { Component } from 'react'; | |||
|
|
|||
| import { Post } from '../Post/Post'; | |||
| import { List } from '../List/List'; | |||
| import { accessToken } from '../../constants'; | |||
| import './UserDetails.scss'; | |||
There was a problem hiding this comment.
Styling import should be the last one among imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.